Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commas in legacy multiline options #150

Merged

Conversation

ziima
Copy link
Collaborator

@ziima ziima commented Mar 12, 2024

We discovered that commas in legacy multiline options are replaced by newline which produced errors on configurations for bump2version.

Debug lead me to autocast which doesn't expect strings with both commas and newlines.

@ziima ziima force-pushed the fix-legacy-multiline branch from f7933a6 to 62dfe8e Compare March 12, 2024 14:30
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (fix-legacy-multiline@c9d67b5). Click here to learn what that means.

❗ Current head 62dfe8e differs from pull request most recent head c3c54b7. Consider uploading reports for the commit c3c54b7 to get more accurate results

Additional details and impacted files
@@                   Coverage Diff                   @@
##             fix-legacy-multiline     #150   +/-   ##
=======================================================
  Coverage                        ?   93.58%           
=======================================================
  Files                           ?       24           
  Lines                           ?     1496           
  Branches                        ?      212           
=======================================================
  Hits                            ?     1400           
  Misses                          ?       67           
  Partials                        ?       29           
Flag Coverage Δ
python-3.10 93.58% <100.00%> (?)
python-3.8 93.58% <100.00%> (?)
python-3.9 93.58% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coordt coordt changed the base branch from master to fix-legacy-multiline March 16, 2024 14:07
@coordt coordt merged commit c40e4f9 into callowayproject:fix-legacy-multiline Mar 16, 2024
1 of 2 checks passed
@ziima ziima deleted the fix-legacy-multiline branch May 15, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants